BIND 10 #2150: Allow DomainTree::find() to start at a lower level

[BIND 10 Development]

#2150: Allow DomainTree::find() to start at a lower level
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120918
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jelte


Comment:

 Hi Jelte

 Replying to [comment:12 jelte]:
 > Looks good, I have a few suggestions for additional tests;
 >
 > - the other failure case for node_path and labelsequence absoluteness
 (i.e. an empty path and a non-absolute labelsequence) if this isn't tested
 somewhere else yet

 Added, but I thought the other tests took care of it! :)

 > - a child that is more than one node away from top() (btw it looks like
 the tree overview at the start of the unit tests file is wrong?)

 From top, I am guessing you mean `chain.top()`. Added. :)

 The tree diagram looks ok to me. What do you think is wrong with it? In
 case you want to see what it really is like, make a `fstream` and call
 `dtree_expose_empty_node.dumpDot()` on it. Run it through GraphViz's dot
 utility (`dot -Tpng foo.dot > foo.png`) and you can compare this and the
 text tree diagram.

 > - a search for a labelsequence from a lower node that would have a
 different result would it have been started in a different node or
 absolute (to make sure it doesn't start out higher anyway).

 Added. :)

-- 
Ticket URL: <https://bind10.isc.org/ticket/2150#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development