BIND 10 #2265: cleanup: remove Renderer::clear() calls

[BIND 10 Development]

#2265: cleanup: remove Renderer::clear() calls
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:
                Type:  task          |                       Status:  new
            Priority:  medium        |                    Milestone:  Next-
           Component:  Unclassified  |  Sprint-Proposed
           Sensitive:  0             |                     Keywords:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 In 1357, we found that essentially it is always mandatory to call
 Renderer::clear() before Message::toWire(), so we put it in there at the
 start. Not doing clear() overwrites the header as the start of the already
 rendered message, leaving the new header uninitialized, and it creates bad
 compressed domain names in the new packets. Apart from that, truncation
 may go wrong, and in case of truncation, the renderer is cleared anyway
 (So there isn't even a reliable contract on whether or not the renderer is
 cleared).

 There are however probably quite a few now unnecessary calls to
 Renderer::clear() that could now be cleaned up.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2265>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development