BIND 10 #2265: cleanup: remove Renderer::clear() calls

BIND 10 Development do-not-reply at isc.org
Tue Sep 18 10:09:54 UTC 2012


#2265: cleanup: remove Renderer::clear() calls
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:
                       Type:  task   |                Status:  new
                   Priority:         |             Milestone:  Next-Sprint-
  medium                             |  Proposed
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jelte):

 nono, no change to toWire() calls, only calls to clear().

 in #1357, we found a problem: if clear() is not called before every single
 call to toWire(), bad things happen. So I porposed to actually do clear()
 in Message::toWire() itself. And if that get's through, we suddenly have a
 lot of unnecessary calls to clear() (everywhere, but in theory easily
 greppable).

 Your suggestion seems fine though

-- 
Ticket URL: <http://bind10.isc.org/ticket/2265#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list