BIND 10 #2238: Pool/Lease Configuration - IPv6

[BIND 10 Development]

#2238: Pool/Lease Configuration - IPv6
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:         |  DHCP-20120917
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  dhcpconf                           |           Sub-Project:  DHCP
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => UnAssigned
 * status:  accepted => reviewing


Comment:

 This ticket is ready for a review. Things to consider:

 - this ticket covers configuration storage only. It is intended to store
 v6 server configuration. The actual configuration parser (that translates
 user's configuration into structures defined) is part of a separate
 ticket, see #2269.

 - Currently classes Pool, Pool6, Subnet, Subnet6 are stored in the same
 files as CfgMgr. As they are part of the CfgMgr, they may be possibly
 defined as internal classes (e.g. CfgMgr::Pool, rather than just a Pool).
 Alternatively, they could be moved to separate files. Finally, they can be
 left as they are now.

 - If would be nice if Pool and Subnet were abstract classes.
 Unfortunately, I couldn't find any method that would be required in both
 derived versions (Pool4 and Pool6) and take a parameter that is common for
 both derived classes.

 - I'm not sure if pointers to Pool and Subnet are really needed. I would
 like to hear reviewer's opinion on that.

 - Parameter inheritance is planned to be implemented as part of the
 configuration parser logic and the inheritance will be done at
 configuration phase. That means that Subnet6 objects will be instantiated
 with their "ultimate" values with inheritance already applied if
 necessary. That will make configuration phase slightly slower, but will
 make the actual operation faster.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2238#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development