BIND 10 #2272: Improve the perfdhcp command_options_helper code.

[BIND 10 Development]

#2272: Improve the perfdhcp command_options_helper code.
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  defect        |  marcin
            Priority:  medium        |                       Status:  new
           Component:  Unclassified  |                    Milestone:  DHCP
           Sensitive:  0             |  2012
         Sub-Project:  DHCP          |                     Keywords:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 After fixing the memory leak reported by Valgrind (commit
 8ad1accced4284ff727b03c43cab755566e486ab) there is a repeating unit tests
 failure on macmini.lab with GCC compiler:
 http://git.bind10.isc.org/~tester/builder/BIND10/20120918045429-MacOSX10.6-x86_64-GCC/logs/unittests.out

 It has been investigated that changing malloc()/free() to new/delete makes
 unit test pass however it was not fully rootcaused. BIND10 dev team
 indicated during a quick review of proposed change that
 command_options_helper code should be improved (exception safety, strcpy
 safety etc). Also it should be better explained why the change from malloc
 to new makes a difference.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2272>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development