BIND 10 #2190: (msgq) select.poll() broken on osx's python

BIND 10 Development do-not-reply at isc.org
Wed Sep 19 10:19:31 UTC 2012


#2190: (msgq) select.poll() broken on osx's python
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120925
  medium                             |            Resolution:
                  Component:  msgq   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  5
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 Since we had both poll and queue code in there already, it seemed even
 easier to just switch around the initialization (i.e. try setting up
 kqueue if available, if not, use poll, it's just a one-time thing anyway,
 and I do now know of any systems where kqueue is offered but known to be
 broken).

 I did run into one problem, see second commit; the statshttpd tests set up
 a wrapped, but real, msgq (something we might need to look into, btw), and
 it never shut it down correctly; this didn't pose much of a problem
 apparently, but it did leave so many things open in my tests that it ran
 out of file descriptors.

 I do not know why it had the weird shutdown-in-finally approach, but it
 seems to me a normal shutdown as patched in the last commit should work.
 Of course I may be missing something here :p

-- 
Ticket URL: <http://bind10.isc.org/ticket/2190#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list