BIND 10 #1357: AXFR and AXFR-like IXFR in needs every message signed

[BIND 10 Development]

#1357: AXFR and AXFR-like IXFR in needs every message signed
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120925
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  xfrin  |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  Low    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Looks ok, one final suggestion, and that is to make doubly sure in a unit
 test that the earlier diffs were not committed;

 I believe we can simply add
 {{{
         self.assertEqual([], self.conn._datasrc_client.committed_diffs)
 }}}

 to the end of test_handle_new_delete_missing_sig, but maybe there's a
 better place.

 Ideally, for that is most important of this last change, we'd also test
 this on the system level. Unfortunately there would be no easy way to
 create these badly signed transfers, so we'd have to defer that until we
 have some form of fake nameserver that can respond with one....

-- 
Ticket URL: <http://bind10.isc.org/ticket/1357#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development