BIND 10 #2187: Remove "cout" statements from libdhcp++

BIND 10 Development do-not-reply at isc.org
Wed Sep 26 10:56:28 UTC 2012


#2187: Remove "cout" statements from libdhcp++
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  enhancement                        |  DHCP-20121004
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  dhcp   |           Sub-Project:  DHCP
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => UnAssigned
 * status:  accepted => reviewing


Comment:

 The code is now ready for review:
 - I removed all informational cout statements from lib/dhcp
 - I throw exception when: detectIfaces, receiveX or send fails (instead of
 printing error)
 - I catch exceptions produced by receiveX and send in DHCP servers and log
 them
 - I also improved some doxygen comments to indicate exceptions being
 thrown
 - I did slight changes to perfdhcp as it uses IfaceMgr.

 Note: I don't throw exceptions when things like pack() fail because we
 spoke with Stephen
 that we would change those functions to void and throw exceptions with
 another ticket.
 I simply added @todo statements there.

 Please review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2187#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list