BIND 10 #2299: use the shortcut DomainTree::find() for finding wildcard

BIND 10 Development do-not-reply at isc.org
Thu Sep 27 19:12:48 UTC 2012


#2299: use the shortcut DomainTree::find() for finding wildcard
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |                       Status:  new
            Priority:  medium        |                    Milestone:  Next-
           Component:  data source   |  Sprint-Proposed
           Sensitive:  0             |                     Keywords:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 I believe the wildcard case of zone_finder.cc:findNode() can
 use the shortcut version of find()

 {{{#!cpp
             // Clear the node_path so that we don't keep incorrect (NSEC)
             // context
             node_path.clear();
             ZoneTree::Result result = tree.find(wildcard_ls, &node,
 node_path,
                                                 cutCallback, &state);
 }}}
 that is, rather than clearing the known path, use the current context
 with the single label of '*' as the search key
 (`LabelSequence::WILDCARD()`).

 This should make the code simpler and faster.  (and, in fact, if we
 don't do this, #2150 would become mostly a waste.)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2299>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list