BIND 10 #2833: refactor relationship between datasrc::ClientList and ZoneTableSegment

BIND 10 Development do-not-reply at isc.org
Tue Apr 2 12:26:20 UTC 2013


#2833: refactor relationship between datasrc::ClientList and ZoneTableSegment
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130402
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  shared memory data source
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Just to check, the current cache loads no dynamic module? So it works with
 static linking?

 I believe calling a wrong type of value a syntax error might be slightly
 confusing. Usually, when someone talks about syntax errors, I imagine
 something like missing parentheses or such. Wrong type of value looks more
 like semantic error.

 {{{#!c++
     /// For other data source types than "MasterFiles", cache can be
 disabled.
     /// In this case cache-zones configuration item is simply ignored,
 even
     /// it contains a syntax or semantics error.
 }}}

 It says the `datasrc_conf` is „system-wide“ configuration. What does it
 mean? Is there some kind of local configuration?

 Here, the param `config` is probably outdated. There's no such parameter
 any more.
 {{{#!c++
     /// \param rrclass The RR class of the zones to be maintained in the
 table.
     /// \param config The configuration based on which a derived object
     ///               is returned.
     /// \return Returns a ZoneTableSegment object
 }}}

 The zero here should be `NULL`:
 {{{#!c++
  prepareSource(Name::ROOT_NAME(), 0);
 }}}

 In these files, the static data source was used because there was in-
 memory data source first and once it stopped being available directly,
 this was the easiest way to switch. Maybe we should switch back now and
 use master-files with some real zone and cache?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2833#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list