BIND 10 #2833: refactor relationship between datasrc::ClientList and ZoneTableSegment

[BIND 10 Development]

#2833: refactor relationship between datasrc::ClientList and ZoneTableSegment
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130423
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  3.87          |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  shared memory data source
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:17 vorner]:
 >
 > > > The zero here should be `NULL`:
 > > > {{{#!c++
 > > >  prepareSource(Name::ROOT_NAME(), 0);
 > > > }}}
 > >
 > > Actually, since the discussion on whether to allow direct evaluation
 > > of pointers as boolean, I've been inclined to use 0 rather than the
 > > macro of `NULL`. [...]
 >
 > I'd be opposed to such switch. Not for some technical reason, but
 generally, you need to expect the existence of the NULL macro anyway,
 since any header might include something that contains it (if not on one
 system, others could have it).
 >
 > And I find it very useful to distinguish zero the number, zero the end
 of string ('\0') and zero the invalid pointer (NULL). Not because the
 compiler couldn't deduce it from the context. But because it helps the
 reader. If I see 0 as a number somewhere, I understand it that the
 function can be told how much of something should there be and we want
 none, not that some object does not exist.

 I understand there are pros and cons.  Anyway it's an off-topic for
 the branch and we've not introduced the change here.

 > > > In these files, the static data source was used because there was
 in-memory data source first and once it stopped being available directly,
 this was the easiest way to switch. Maybe we should switch back now and
 use master-files with some real zone and cache?
 > >
 > > Please see my previous "quick question" and clarify what this is
 > > about.
 >
 > Ah, I forgot to paste the file names. Yes, the python tests:
 >  * `src/lib/python/isc/datasrc/tests/datasrc_test.py`
 >  * `src/lib/python/isc/datasrc/tests/zone_loader_test.py`
 >
 > The new code contains this strange sentence:
 > {{{
 > it contains an error that would other trigger an exception.
 > }}}
 >
 > What is meant by other? Should it be otherwise?
 >
 > I think these are minor enough, I don't need to see it again. So, please
 merge.

 Oops, that was meant to be "otherwise".  Fixed this, and updated the
 Python tests using "normal" in memory zones.  The latter changes may
 be a bit beyond the trivial level, but are probably minor enough.

 So I've merged the branch, and am now closing the ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2833#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development