BIND 10 #2879: notify_out doesn't handle response to NOTIFY correctly

[BIND 10 Development]

#2879: notify_out doesn't handle response to NOTIFY correctly
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  xfrout        |  accepted
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130423
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 I'm releasing this ticket for now (as #2831 is back to me).

 I figured out the cause of the problem: `_zone_notify_handler()`
 should compare the return value from `_handle_notify_reply()` against
 `_REPLY_OK`, not just evaluate it as a boolean:
 {{{#!python
                 if self._handle_notify_reply(zone_notify_info, reply,
 tgt):
                     self._notify_next_target(zone_notify_info)
 }}}

 According to the history this problem seems to have been there almost
 since the introduction of notify_out.py three years ago.  This also
 means this method (or this module in general) is so poorly tested.
 So I planned to make at least `_handle_notify_reply()` fully tested,
 not just to fix this particular issue and add a test case for this
 particular point.  But I've not done any of these yet.

 I've made a branch trac2879 and just committed some editorial cleanups.
 If someone is in the state of looking for a new open task, feel free
 to continue it based on the above analysis.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2879#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development