BIND 10 #2387: support generic version of rdata::createRdata(text) in DNSKEY, NSEC3, NSEC3PARAM

[BIND 10 Development]

#2387: support generic version of rdata::createRdata(text) in DNSKEY, NSEC3,
NSEC3PARAM
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  closed
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130423
           Sensitive:  0             |                   Resolution:  fixed
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  5             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  8
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to the `master` branch in commit
 `937635d75665f331226774ca1b7c5bff791b9d69`:
 {{{
 * 1b9e343 [2387] Revert "Add some assertions anyway"
 * 3c704fc [2387] suggested editorial cleanups to doxygen doc: make it
 formal and unified.
 * f820531 [2387] Rearrange code
 * 9a04595 [2387] Move text about missing key data to the constructor API
 doc
 * 82fc64b [2387] Add comments on use of auto_ptr
 * e8b5540 [2387] Add includes
 * 3f9a24a [2387] Remove default data from wiredata .spec files
 * 65f68f7 [2387] Add some assertions anyway
 * 0e61367 [2387] style: fixed a long line
 * 785ade5 [2387] Fix leaks
 * 8565517 [2387] Test NSEC3PARAM operator= correctly
 * 4931689 [2387] Test DNSKEY operator= correctly
 * 2b43116 [2387] Move short keydata check for RSA/MD5 into getTag()
 * dfd5516 [2387] Permit missing key data in DNSKEY RDATA
 * 4778557 [2387] Add unmatched parenthesis testcases that cause lexer
 failures (when looking for string)
 * 7b2ee20 [2387] Add tests for trailing garbage in strings
 * 61dcaac [2387] Remove unused includes
 * 281c6ab [2387] Update test data to be more consistent
 * 8b106d2 [2387] Fix key digest to match the test data
 * 8117b69 [2387] Add DNSKEY support in wire data generator
 * ea89361 [2387] Move string construction out of loop
 * e42c4c8 [2387] Remove unnecessary checks
 * 8e3eb15 [2387] style fix: folded a long line.
 * edd462b [2387] added toWireBuffer tests for DNSKEY and NSEC3PARAM.
 * 29ec8dc [2387] Unify code from MX constructors
 * c70bba0 [2387] Unify NSEC3PARAM string and lexer constructor tests
 * ad6d161 [2387] Remove some redundant variables that shadow the member
 variable
 * b5d7336 [2387] Rewrite unified NSEC3 tests using helper methods
 * aaace1a [2387] Update coding style
 * a852fc0 [2387] Rewrite unified tests using helper methods
 * 53e18a3 [2387] Unify string and lexer constructor tests
 * a1ce848 [2387] Rearrange some code
 * 393534a [2387] Add NSEC3PARAM test for bad base32 hex sequence
 * 98b10b7 [2387] Add number vs non-number tests
 * ed58ec0 [2387] Use a slightly more efficent getString()
 * 0ecc1e0 [2387] Support empty bitmaps in buildBitmapsFromLexer()
 * 09fff7c [2387] Add a code comment
 * 2045020 [2387] Keep extracting strings until end-of-input, and throw
 otherwise
 * 945103c [2387] Unify constructor API documentation
 * 6fc763d [2387] Remove duplicate testcase
 * bbed8c3 [2387] Use valid Base64 encoding in test
 * 55fe56a [2387] Remove duplicate # in front of ticket numbers
 * 23eca85 [2387] Change code to use a reference instead
 * 09ed404 [2387] Add DNSKEY wire test for short keydata for RSA/MD5
 * 46cfb5c [2387] Make DNSKEY wire constructor throw on empty keydata
 * b6bd579 [2387] Add key data size check in InputBuffer constructor too
 * 8ee676b [2387] Point to the RFC about why key data has to be at least 3
 bytes long
 * 0318fc1 [2387] Update exception description in API doc
 * d124a5b [2387] trivial (unrelated) cleanups: constify and indentation
 fix.
 * 72922ff [2387] Add API doc for NSEC3PARAM constructors
 * aa95c10 [2387] Add more NSEC3PARAM unittests
 * 4e379f9 [2387] Remove now unused parseNSEC3ParamText() function
 * fb7adf3 [2387] Update NSEC3PARAM string RDATA constructor to use
 MasterLexer
 * 0c8f405 [2387] Add NSEC3PARAM lexer constructor implementation
 * 926dd63 [2387] Update API doc for NSEC MasterLexer constructor
 * 863be53 [2387] Add API doc for DNSKEY constructors
 * 86f31f3 Add API doc for NSEC3 constructors
 * f909b68 [2387] Add API doc for parseNSEC3ParamFromLexer()
 * 9926f9b [2387] Add more NSEC3 unittests
 * 947d85d [2387] Fix empty bitmap case
 * 61068e2 [2387] Remove now unused buildBitmapsFromText()
 * 2f41159 [2387] Add namespace to argument's type
 * 8a91e6e [2387] Add NSEC3 string RDATA constructor
 * 240e533 [2387] Add NSEC3 lexer constructor implementation
 * 22362bb [2387] Don't support trailing comments in DNSKEY string
 constructor
 * fdfe820 Revert "[2387] Allow comments at the end of DS like string data"
 * 167b544 [2387] Re-enable previously disabled tests
 * 00d53a3 [2387] Allow comments at the end of DS like string data
 * 8674224 [2387] Allow whitespace in the DNSKEY public key
 * 3de4eca [2387] Update std::string DNSSEC constructor
 * f43b44e [2387] Add DNSKEY implementation
 * 7c41946 [2387] Delete trailing whitespace
 }}}

 Resolving as fixed. Thank you for the reviews Jinmei.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2387#comment:29>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development