BIND 10 #2877: slow updates to SQLite3 data source

BIND 10 Development do-not-reply at isc.org
Wed Apr 10 16:36:05 UTC 2013


#2877: slow updates to SQLite3 data source
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130423
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:15 vorner]:
 > It turned out to be simpler than I expected. So, ready for review again.

 The changes basically look okay.  I made a few minor cleanups.

 One additional comment: in database_unittest, we might use upper case
 characters for the template parameter:
 {{{#!cpp
     template<size_t PARAM_COUNT>
     void deleteRecord(Domains& domains, const string
 (&params)[PARAM_COUNT]) {
 }}}

 so that it's clearer in the source code that param_count is not a
 normal variable.

 But this is not per the guideline but rather a matter of taste, so I'd
 leave it to you.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2877#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list