BIND 10 #2877: slow updates to SQLite3 data source
BIND 10 Development
do-not-reply at isc.org
Thu Apr 11 10:01:13 UTC 2013
#2877: slow updates to SQLite3 data source
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | vorner
Priority: medium | Status:
Component: data source | closed
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130423
Sub-Project: DNS | Resolution: fixed
Estimated Difficulty: 3 | CVSS Scoring:
Total Hours: 4.21 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* status: reviewing => closed
* totalhours: 1.2 => 4.21
* resolution: => fixed
Comment:
Hello
Replying to [comment:16 jinmei]:
> The changes basically look okay. I made a few minor cleanups.
>
> One additional comment: in database_unittest, we might use upper case
> characters for the template parameter:
> {{{#!cpp
> template<size_t PARAM_COUNT>
> void deleteRecord(Domains& domains, const string
(¶ms)[PARAM_COUNT]) {
> }}}
I don't think this is consistent with the rest of the code. If you look at
templates (which are usually class names), they are usual CamelCase for
class names (or single-character identifiers). So it seems more consistent
to leave it as ordinary variable, instead of using a constant.
The branch is merged.
--
Ticket URL: <http://bind10.isc.org/ticket/2877#comment:19>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list