BIND 10 #2832: extend data source config to specify shmem segment params

BIND 10 Development do-not-reply at isc.org
Fri Apr 12 22:19:23 UTC 2013


#2832: extend data source config to specify shmem segment params
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130423
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  shared memory data source
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:14 pselkirk]:
 > I added value checking in getSegmentTypeFromConf, so that it only
 accepts "local" and "mapped".
 > Also added a unittest case that tries to set it to "bogus".

 Hmm, I actually intended to test it for
 src/bin/cfgmgr/plugins/datasrc_config_plugin.py
 but I now realized it wouldn't work as its checker disables cache.

 Also, my intent was to have `CacheConfig` treat cache-type opaque
 string and validate the type only in `ZoneTableSegment::create()`.
 And, "mapped" type would probably be optional partly because it causes
 some unsolvable portability issue (at least in near time).

 Within the C++ code we already test `ZoneTableSegment::create()`
 reject a very unlikely name and confirm "cache-type" config value will
 be returned by `getSegmentType()`, so I now think we don't need any
 new test to this end.

 The typo fix in 946b1dfec880e605bc154bc963f4b3bd860c1b55 looks
 correct, so I suggest only leaving it and committing it without the
 additional check and test.

 I'm attaching a diff to do this.  If you agree, please apply it and
 merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2832#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list