BIND 10 #2834: update ConfigurableClientList::getCachedZoneWriter with new interface
BIND 10 Development
do-not-reply at isc.org
Tue Apr 23 11:18:41 UTC 2013
#2834: update ConfigurableClientList::getCachedZoneWriter with new interface
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: Unclassified | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130423
Sub-Project: DNS | Resolution:
Estimated Difficulty: 4 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| shared memory data source
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
First, the code itself looks almost OK. But I don't see how it fits into
the whole picture. What does the ticket do/why is it needed? Or is it just
cleanup/refactoring ticket? It seems there are too many layers around to
see what each one of them actually does.
Also, several files now contain tabs.
I guess the files `src/lib/datasrc/tests/zone_finder_context_unittest.cc`
and `src/lib/datasrc/tests/zone_loader_unittest.cc` could benefit from
using the `loadZoneIntoTable` function.
--
Ticket URL: <http://bind10.isc.org/ticket/2834#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list