BIND 10 #2521: support generic version of rdata::createRdata(text) in RRSIG, DHCID, OPT RDATA

[BIND 10 Development]

#2521: support generic version of rdata::createRdata(text) in RRSIG, DHCID, OPT
RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  pselkirk
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130423
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by pselkirk):

 Replying to [comment:14 jinmei]:
 > '''dhcid_49.cc'''
 >
 > - createFromLexer: this revised version seems to have a regression
 >   that space-separated multiple base64 chunks aren't recognized.
 >   Assuming I'm right, this also means tests are not sufficient.

 You're right.

 Is there are better way to get all remaining text from the lexer than just
 calling getNextToken() repeatedly?

 Also, this means we can't detect extra text beyond the end of the digest,
 so I'll have to remove that check from the string constructor.

 > - createFromLexer: not due to this branch, but I'm not sure if we need
 >   to have this check:
 > {{{#!cpp
 >     // RFC4701 states DNS software should consider the RDATA section to
 >     // be opaque, but there must be at least three bytes in the data:
 >     // < 2 octets >    Identifier type code
 >     // < 1 octet >     Digest type code
 > }}}
 >   At least BIND 9 doesn't have this check.

 It seems that Dima added it in the original implementation. It makes sense
 to me, but I don't mind removing it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2521#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development