BIND 10 #2712: Cmdctl shutdown command does not shut down b10-cmdctl

[BIND 10 Development]

#2712: Cmdctl shutdown command does not shut down b10-cmdctl
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  cmd-ctl       |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130423
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  6             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:12 vorner]:

 > Replying to [comment:9 jinmei]:

 > However, it'll stop working if we ever unify the sessions (using just
 one from cfgmgr), because msgq refuses to send messages back to the
 sender, even if it is addressed there. Do you have idea why the special
 code is there?

 I have no idea; I checked the code history, but it seemed to be coded
 that way almost from the beginning without specific commit log for
 that particular part.  In any case, if and when we unify the session,
 at least we should be able to notice the regression via the added
 lettuce test, so I think it's okay to think about an alternative at
 the point if and when it actually happens.

 > Some comments to the code:
 >
 > Could you describe the motivation of the
 `test_handle_post_request_to_itself`, for example in the docstring?

 Oops, actually, that test wasn't intended to be added.  I simply
 removed it (see also the commit log).

 > I believe this should be „quit“, not „quite“:
 > {{{
 >         # shutdown.  So "send bind10 command" will fail (it cannot
 complete
 >         # "quite").
 > }}}

 Good catch, corrected.

 > I'm confused by this comment:
 > {{{
 >     ignore_failure ('ignoring failure', optional): set to not None if
 bindctl
 >     is expected to fail (and it's acceptable).
 >
 >     Fails if bindctl does not exit with status code 0 and ignore_failure
 >     is not None.
 > }}}
 >
 > So, if `ignore_failure` is set to `None` (a false value), is the failure
 ignored?

 if `ignore_failure` is set to None, failure is detected and causes a
 test failure (which is the previous behavior and the default of the
 new version).  I think the documentation is not incorrect, but
 admittedly it can be confusing due to the kind of double-negation.
 I've updated it so it'll hopefully be less confusing.  Is that better?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2712#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development