BIND 10 #2887: "make check" fails on FreeBSD 9.1
BIND 10 Development
do-not-reply at isc.org
Thu Apr 25 22:03:32 UTC 2013
#2887: "make check" fails on FreeBSD 9.1
-------------------------------------+-------------------------------------
Reporter: jwright | Owner:
Type: defect | jinmei
Priority: medium | Status:
Component: tests | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130423
Sub-Project: DNS | Resolution:
Estimated Difficulty: 3 | CVSS Scoring:
Total Hours: 0 | Defect Severity:
| Medium
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Thanks for the review.
Replying to [comment:20 pselkirk]:
> It generally looks fine as far as it goes.
>
> I'm a little disconcerted about the tests that still fail, but it seems
to be a matter of one kind of exception versus another.
>
> The one quibble I have is with the implicit test for NULL in rdataset.cc
and tsigrecord.cc. The BIND 9 Coding Guidelines say "Testing to see
whether a pointer is NULL should be explicit." But the BIND 10 Coding
Guidelines are silent on the matter.
Ah, good catch. Actually, we decided to change the guideline a while
ago, but we forgot to update the wiki page. I just updated it
clarifying this point:
http://bind10.isc.org/wiki/CodingGuidelines#NULLpointercheck
> No issues with the proposed changelog.
Just checking: so is it okay to merge this branch?
--
Ticket URL: <http://bind10.isc.org/ticket/2887#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list