BIND 10 #2887: "make check" fails on FreeBSD 9.1

[BIND 10 Development]

#2887: "make check" fails on FreeBSD 9.1
-------------------------------------+-------------------------------------
            Reporter:  jwright       |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  tests         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130423
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:23 pselkirk]:

 > > > The one quibble I have is with the implicit test for NULL in
 rdataset.cc and tsigrecord.cc. The BIND 9 Coding Guidelines say "Testing
 to see whether a pointer is NULL should be explicit." But the BIND 10
 Coding Guidelines are silent on the matter.
 > >
 > > Ah, good catch.  Actually, we decided to change the guideline a while
 > > ago, but we forgot to update the wiki page.  I just updated it
 > > clarifying this point:
 http://bind10.isc.org/wiki/CodingGuidelines#NULLpointercheck
 >
 > Over the past 25 years, I've argued both sides of this vigorously, but
 I've been on the "explicit" side for long enough that the the implicit
 just looks wrong to me now. That said, I'm more for consistency than
 purity.
 >
 > > Just checking: so is it okay to merge this branch?
 >
 > Okay to merge.

 Okay, thanks.  Merge done, closing.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2887#comment:24>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development