BIND 10 #2252: Implement counters into Xfrin (1/3)

[BIND 10 Development]

#2252: Implement counters into Xfrin (1/3)
-------------------------------------+-------------------------------------
            Reporter:  naokikambe    |                        Owner:
                Type:  enhancement   |  naokikambe
            Priority:  medium        |                       Status:
           Component:  xfrin         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130514
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  16.75         |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by naokikambe):

 Replying to [comment:27 jinmei]:
 > > > > I revised the codes to treat an xfr request as success in a case
 of raised `XfrinZoneUptodate`. For consistency between BIND 9 and 10, I
 think we should define this case as success. In fact, `do_xfrin()` already
 defines so. The commit is:
 > > > > {{{
 > > > > 8544c8e [2252] treat an xfr request as success with an
 XfrinZoneUptodate raised
 > > > > }}}
 > > >
 > > > Documentation update is missing.
 > >
 > > Documentation was not same but I've updated a bit. The commit is:
 > > {{{
 > > 4b79543 [2252] update documentation for the test cases
 > > }}}
 >
 > By documentation I meant the description of the man page.  I've pushed
 > my suggested text.

 Sorry for my misunderstanding. The proposed text looks good. I corrected
 XML tags.

 {{{
 6b3b78f [2252] replace ending tags
 }}}

 Replying to [comment:29 jinmei]:
 > One last additional note: #2879 has been merged to master, so you'll
 > probably have to (or simply can) adjust the lettuce test on merge.

 I removed cares for #2879 from `xfrin_notify_handling.feature`. And I
 merged the master including the changes in #2879 into the branch.

 {{{
 199beea [2252] Merge branch 'master' of git://git.bind10.isc.org/bind10
 into trac2252
 0a2277b [2252] adjust lettuce tests; xfrin_notify_handling.feature
 }}}

 BTW the branch doesn't pass lettuce test on the build farm:
 http://git.bind10.isc.org/~tester/builder//BIND10-lettuce/20130426125701
 -DebianLinux-x86_64-GCC/logs/lettuce.out

 I've seen it before on my environment, which I commented at comment:19.
 I'm going to investigate it, and I'd fix the error or add a workaround. So
 I continue to work on this ticket.


 Regards,

-- 
Ticket URL: <https://bind10.isc.org/ticket/2252#comment:30>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development