BIND 10 #2811: Make some DomainTree code updates

[BIND 10 Development]

#2811: Make some DomainTree code updates
-------------------------------------+-------------------------------------
            Reporter:  muks          |                        Owner:  muks
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  data source   |                    Milestone:
            Keywords:                |  Sprint-20130806
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 Just few questions. What is the motivation for this change?
 {{{#!diff
      } else if (order < 0) {
          node->setSubTreeRoot(false);
          parent->left_ = node;
 +        insertRebalance(current_root, node);
      } else {
          node->setSubTreeRoot(false);
          parent->right_ = node;
 +        insertRebalance(current_root, node);
      }
 -    insertRebalance(current_root, node);
 +
      if (new_node != NULL) {
 }}}

 Looking at the loop, shouldn't we stop it after the first rotation?

 In the sorted test, I think we need 7 digits, 6 is not enough.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2811#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development