BIND 10 #2264: Pkt4::pack() and Pkt6::pack() should throw an exception on failure

[BIND 10 Development]

#2264: Pkt4::pack() and Pkt6::pack() should throw an exception on failure
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  enhancement   |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130731
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * owner:  tmark => stephen


Comment:

 Replying to [comment:11 stephen]:
 > Reviewed commit f395f315a51a23ac058456ec15580231f145bd75
 >
 > I think change is sufficiently small enough not to need a !ChangeLog
 entry.
 >
 > '''src/bin/dhcp4/dhcp4_srv.cc'''[[BR]]
 > The change has removed the DHCP4_PACK_FAIL error; this should be removed
 from the message file as well.
 >

 Message removed.

 > '''src/bin/dhcp6/dhcp6_srv.cc'''[[BR]]
 > The change has removed the DHCP6_PACK_FAIL error; this should be removed
 from the message file as well.

 Message removed.

 >
 > '''src/lib/dhcp/pkt6.cc'''[[BR]]
 > '''src/lib/dhcp/pkt6.{cc,h}'''[[BR]]
 > packUDP():  Method header needs to be altered.  The method has been
 implemented and throws an !InvalidOperation exception on an error.
 >

 Corrected.

 > packTCP(): Method header needs to be altered to indicate the exception
 thrown.  Currently the code throws the "Unexpected" exception: I suggest
 that "!NotImplemented" would be a better choice. (If this is changed, the
 header for pack() needs to be altered.)


 Method changed to throw !NotImplemented.  Method commentary changed
 accordingly.
 Changes commited under git 27d057a79de7e769cef2a87e59e08807491bf44e

-- 
Ticket URL: <http://bind10.isc.org/ticket/2264#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development