BIND 10 #3052: Create QueueMgr class for D2

BIND 10 Development do-not-reply at isc.org
Mon Aug 5 15:37:28 UTC 2013


#3052: Create QueueMgr class for D2
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp-ddns     |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130731
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => tmark


Comment:

 Replying to [comment:7 tmark]:
 > > constructionTests: Everytime the new !QueueMgr object is allocated it
 should be enclosed in ASSERT_NO_THROW rather than EXPECT_NO_THROW. This is
 because, if the construction fails, calling the method on the object will
 result in assertion. The assert would exit the test.
 > > The same issue applies to all other tests.
 >
 > Stephen's rule of thumb for this is that if the remainder of test cannot
 pass,
 >  use an ASSERT.  I am not always dilligent about checking this
 especially when
 > enerating lots of new tests.
 >
 > In the case of constructionTest, I have left them as EXPECTs.  That way
 you can see if all variant fail or only some.  Each construction scenario
 stands on it's own.
 >
 If you have a concern that other variants will not be tested you could
 split the test into multiple simple tests and for each add ASSERT. What do
 you think?

 With regards to the !ChangeLog... I don't know how I missed the entry in
 the original comment. :-)

-- 
Ticket URL: <http://bind10.isc.org/ticket/3052#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list