BIND 10 #3016: Change the type of Auth server statistics counter to uint64_t and use lower 63bit

BIND 10 Development do-not-reply at isc.org
Wed Aug 7 07:58:41 UTC 2013


#3016: Change the type of Auth server statistics counter to uint64_t and use lower
63bit
-------------------------------------+-------------------------------------
            Reporter:  fujiwara      |                        Owner:
                Type:  defect        |  fujiwara
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130820
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  1             |                 CVSS Scoring:
         Total Hours:  0.26          |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by fujiwara):

 Replying to [comment:11 vorner]:
 > Yes, instead of `unsigned long long`. But I don't mean the values of
 counters. I mean this code:
 >
 > {{{#!c++
 >     for (long long int i = 0; i < 4294967306LL; i++) {
 >         counter.inc(ITEM1);
 >     }
 > }}}
 >
 > I think `i` should be `uint64_t` too, for consistency with the rest of
 the code.

 I used "long long" loop variable because C99 specifies sizeof(long long
 int) >= 64bit and constant 4294967306LL has a type "long long int", not
 int64_t or uint64_t.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3016#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list