BIND 10 #3082: Implement DHCPv4 Client FQDN option (81)

[BIND 10 Development]

#3082: Implement DHCPv4 Client FQDN option (81)
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  enhancement   |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp-ddns     |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130821
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by tmark):

 I forgot to run cppcheck, it spit out the following errors:

 src/lib/dhcp/option4_client_fqdn.cc:273: check_fail: 'operator=' should
 check for assignment to self to avoid problems with dynamic memory.
 (warning,operatorEqToSelf)
 src/lib/dhcp/option4_client_fqdn.cc:67: check_fail: Function parameter
 'name_type' should be passed by reference. (performance,passedByValue)
 src/lib/dhcp/option4_client_fqdn.cc:118: check_fail: Function parameter
 'name_type' should be passed by reference. (performance,passedByValue)
 src/lib/dhcp/option_data_types.cc:173: check_fail: Possible inefficient
 checking for 'buf' emptiness. (performance,stlSize)

 Aren't I nice?  I saved you from a build farm failure!

-- 
Ticket URL: <https://bind10.isc.org/ticket/3082#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development