BIND 10 #2690: use select instead of poll/kqueue in msgq
BIND 10 Development
do-not-reply at isc.org
Wed Aug 14 10:21:03 UTC 2013
#2690: use select instead of poll/kqueue in msgq
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | vorner
Priority: medium | Status:
Component: msgq | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130820
Sub-Project: Core | Resolution:
Estimated Difficulty: 4 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => vorner
Comment:
Hi Michal
Here are my review comments:
* The unused message ids should be removed from `msgq_messages.mes`.
* Lettuce tests fail for me, but it seems to be unrelated. See #3094.
* What is the purpose of this statement:
{{{
write_ready = set(write_ready)
}}}
I follow what it does, but did something make you write that statement?
* Can this use the code in `isc.server_common.bind10_server`?
* Unittests for `run_select()` for testing various combinations of reads
and writes seem to be missing. The old code had tests that checked if
a read caused an fd to disappear and a subsequent write attempt didn't
cause any exceptions. You handle this case in the new select code, but
it's not unittested.
--
Ticket URL: <http://bind10.isc.org/ticket/2690#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list