BIND 10 #2981: Implement Hooks Framework (part 3) - BIND 10 configuration

[BIND 10 Development]

#2981: Implement Hooks Framework (part 3) - BIND 10 configuration
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  enhancement   |  stephen
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130821
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen


Comment:

 Replying to [comment:5 stephen]:
 > However, there is a longer-term problem because I've just realized that
 the parser for the MySQL data is of the same type - the "commit" closes
 the current database and opens a new one. At the moment the rollback for
 this is ignored, but it should be treated in the same way - but then how
 do we handle the case when we have two parsers whose commit() action can't
 be rolled back?  We may want to open a ticket for this.

 Can you file the ticket?

 > > '''src/bin/dhcp4/tests/config_parser_unittest.cc'''
 > > In most of the cases we start names of the tests with the lower case
 letter. However, I know that it is not followed everywhere.
 > We might want to raise a ticket for this.

 So I understand that you defer fixing names of the tests that you have
 created here, so as they are fixed with this new ticket?

 > > !HooksLibrariesParser Constructor description: The name of the
 parameter is ''hooks-libraries'', not ''hooks_libraries''.
 > Fixed.

 dhcp_parsers.h (line 371) still has it.

 >
 > > HooksLibrariesParser::getLibraries: The doxygen convention to mark the
 parameter ''out'' is:
 > Corrected.

 Actually, it should be:
 {{{
     /// @param [out] libraries List of libraries that were specified in
 the
     ///        new configuration.
 }}}

 >
 > > Should this ticket have !ChangeLog entry?
 > Yes.  Suggested text is:
 > {{{
 > Added capability to configure the hooks libraries through the BIND 10
 > configuration mechanism.
 > }}}

 This implementation adds configuration of the hooks for DHCP Server.
 Please consider mentioning that it is the change in b10-dhcp6 and
 b10-dhcp4.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2981#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development