BIND 10 #3082: Implement DHCPv4 Client FQDN option (81)

[BIND 10 Development]

#3082: Implement DHCPv4 Client FQDN option (81)
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp-ddns     |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130821
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => tmark


Comment:

 Replying to [comment:5 tmark]:
 > I forgot to run cppcheck, it spit out the following errors:
 >
 > src/lib/dhcp/option4_client_fqdn.cc:273: check_fail: 'operator=' should
 check for assignment to self to avoid problems with dynamic memory.
 (warning,operatorEqToSelf)
 > src/lib/dhcp/option4_client_fqdn.cc:67: check_fail: Function parameter
 'name_type' should be passed by reference. (performance,passedByValue)
 > src/lib/dhcp/option4_client_fqdn.cc:118: check_fail: Function parameter
 'name_type' should be passed by reference. (performance,passedByValue)
 > src/lib/dhcp/option_data_types.cc:173: check_fail: Possible inefficient
 checking for 'buf' emptiness. (performance,stlSize)
 >
 > Aren't I nice?  I saved you from a build farm failure!
 >

 You are nice. But the two warnings about passing enum by reference do not
 make sense. Also, I can't reproduce them. I took care of the other two.
 One is addressed, another one is suppressed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3082#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development