BIND 10 #3062: Create generic "CalloutHandle" store

BIND 10 Development do-not-reply at isc.org
Thu Aug 15 13:51:41 UTC 2013


#3062: Create generic "CalloutHandle" store
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  enhancement   |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130821
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * owner:  UnAssigned => stephen


Comment:

 Changes seem fine.  I do have one question:

 Is the equality test used in getCalloutHandler sufficient to consider the
 two packet pointers equal?  As these are shared pointers, this amounts to
 a.get() == b.get(), which would compare the allocated pointer values,as
 opposed to *(a.get()) == *(b.get()) (if the packet classes had ==
 defined)?  Basically, is there any risk that in procesing a packet, we
 throw it what was allocated and replace it midstream?   If not, then this
 should be fine, but maybe worth a comment?

-- 
Ticket URL: <http://bind10.isc.org/ticket/3062#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list