BIND 10 #3099: Bogus error message in b10-xfrin if no tsig key used

[BIND 10 Development]

#3099: Bogus error message in b10-xfrin if no tsig key used
-------------------------------------+-------------------------------------
            Reporter:  shane         |                        Owner:
                Type:  defect        |                       Status:  new
            Priority:  medium        |                    Milestone:  Next-
           Component:  xfrin         |  Sprint-Proposed
            Keywords:                |                   Resolution:
           Sensitive:  0             |                 CVSS Scoring:
         Sub-Project:  DNS           |              Defect Severity:
Estimated Difficulty:  0             |  Medium
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Description changed by shane:

Old description:

> I was setting up a secondary from a master that was blocking AXFR still,
> and I got the following error message:
>
> {{{
> 2013-08-15 14:08:59.019 ERROR [b10-xfrin.xfrin/647]
> XFRIN_XFR_PROCESS_FAILURE IXFR transfer of zone example.org./IN failed:
> XfrinConnection instance has no attribute 'tsig_key_name'
> }}}
>
> It turns out that this comes from an error message in b10-xfrin:
>
> {{{#!python
>     def connect_to_master(self):
>         '''Connect to master in TCP.'''
>
>         try:
>             self.connect(self._master_addrinfo[2])
>             return True
>         except socket.error as e:
>             logger.error(XFRIN_CONNECT_MASTER, self.tsig_key_name,
>                          self._master_addrinfo[2],
>                          str(e))
>             return False
>
> }}}
>
> The problem is that there is no "tsig_key_name" in the object.
>
> I've made a fix that improves the error message and fixes this bug, and
> attached it here.
>
> The error message now looks like this:
>
> {{{
> XFRIN_CONNECT_MASTER error connecting to master at ('2001:db8::1', 53)
> for example.org.: [Errno 111] ECONNREFUSED
> }}}
>
> It only includes TSIG information if actually specified.

New description:

 I was setting up a secondary from a master that was blocking AXFR still,
 and I got the following error message:

 {{{
 2013-08-15 14:08:59.019 ERROR [b10-xfrin.xfrin/647]
 XFRIN_XFR_PROCESS_FAILURE IXFR transfer of zone example.org./IN failed:
 XfrinConnection instance has no attribute 'tsig_key_name'
 }}}

 It turns out that this comes from an error message in b10-xfrin:

 {{{#!python
     def connect_to_master(self):
         '''Connect to master in TCP.'''

         try:
             self.connect(self._master_addrinfo[2])
             return True
         except socket.error as e:
             logger.error(XFRIN_CONNECT_MASTER, self.tsig_key_name,
                          self._master_addrinfo[2],
                          str(e))
             return False

 }}}

 The problem is that there is no "tsig_key_name" in the object.

 I've made a fix that improves the error message and fixes this bug, and
 attached it here.

 The error message now looks like this:

 {{{
 XFRIN_CONNECT_MASTER error connecting to master at ('2001:db8::1', 53) for
 example.org.: [Errno 111] ECONNREFUSED
 }}}

 It only includes TSIG information if actually specified. (Note that I
 haven't actually checked this with a valid TSIG key since I don't use
 TSIG... should be done in review!)

--

-- 
Ticket URL: <http://bind10.isc.org/ticket/3099#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development