BIND 10 #3082: Implement DHCPv4 Client FQDN option (81)

[BIND 10 Development]

#3082: Implement DHCPv4 Client FQDN option (81)
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  enhancement   |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp-ddns     |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130821
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by marcin):

 I addressed the comments from the second review. Also, I discovered that
 there were a few warnings in doxygen, which I fixed.

 There were a few comments in #3036 which also apply to this ticket. These
 are:
 - toText() should not return multi-line indented text, but one-liner. I am
 not very happy with it (because it is less readable), but it is true that
 we follow this convention for other options, so I changed it to one-liner
 to make it consistent with other options.
 - The checkFlags() function used to always check that MBZ bits are zeroed.
 When the received packet is parsed we rather want to ignore MBZ bits
 because we should not discard the option because MBZ bits being non-zero.
 I added parameter to checkFlags() to control whether MBZ is checked or
 not. For the constructor which is used to parse received packet, I use
 this parameter to disable validation of MBZ.

 Because of these additional changes, I am pushing it back to review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3082#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development