BIND 10 #3028: Cmdctl print_settings - conflict between behavior and help documentation

BIND 10 Development do-not-reply at isc.org
Mon Aug 19 03:26:04 UTC 2013


#3028: Cmdctl print_settings - conflict between behavior and help documentation
-------------------------------------+-------------------------------------
            Reporter:  bconry        |                        Owner:
                Type:  defect        |  vorner
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130820
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  UnAssigned => vorner


Comment:

 Hi Michal

 Your patch looks good, but I don't like this command at all. Primarily it
 seems to be used to test that `command_handler()` handles commands. We
 should do one of the following:

 * Make it a very simple test returning some known fixed string and call it
 a `test_command`
 * Make it a publicly documented command that prints the settings, and use
 it in testing as-is
 * Just remove it altogether (other commands like `shutdown` won't work
 without being handled in cmdctl). Also remove the commented line in
 `b10-cmdctl.xml`.
 * Put it in a derived class `MyCommandControl` that exists in
 `cmdctl_test.py` that calls `super()` for all other commands except
 `test_command`.

 But for now if you want to simply merge this, please go ahead.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3028#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list