BIND 10 #3049: Fix offset_ptr test in ax_boost_for_bind10.m4 and configure.ac
BIND 10 Development
do-not-reply at isc.org
Mon Aug 19 03:33:54 UTC 2013
#3049: Fix offset_ptr test in ax_boost_for_bind10.m4 and configure.ac
-------------------------------------+-------------------------------------
Reporter: muks | Owner:
Type: defect | vorner
Priority: medium | Status:
Component: build system | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130820
Sub-Project: DNS | Resolution:
Estimated Difficulty: 2 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: UnAssigned => vorner
Comment:
Hi Michal
Replying to [comment:4 vorner]:
> I did what the ticket said. I don't think it is important enough for
changelog entry (we don't know about any actual breakage that this might
have caused).
*Nod*. I guess this was added for some very specific platform, and it was
broken all this time, so I don't know if anyone even noticed it.
> However, I'm not completely sure the original was broken ‒ if the
`-Werror` is not passed, the test does not fail and therefore we don't
error. Do we need the change?
Even if `-Werror` was passed, the test was compiled without `-Werror` at
that point. So the test always passed (even if it generated a warning).
Instead it should be compiled with `-Werror` all the time (even if
`-Werror` is disabled) as it's just detection code.
I'm not sure if even this test is required as nobody seems to have noticed
it.
The branch is fine, so please go ahead and merge it.
--
Ticket URL: <http://bind10.isc.org/ticket/3049#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list