BIND 10 #2892: blank client_id/server_id don't causes DHCPv6 server to discard messages

[BIND 10 Development]

#2892: blank client_id/server_id don't causes DHCPv6 server to discard messages
-------------------------------------+-------------------------------------
            Reporter:  wlodekwencel  |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  dhcp6         |  reviewing
            Keywords:  dhcp,         |                    Milestone:
  client_id, server_id               |  Sprint-DHCP-20130821
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:
         Total Hours:  0             |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by wlodekwencel):

 * owner:   => UnAssigned
 * status:  new => reviewing
 * milestone:  DHCP Outstanding Tasks => Sprint-DHCP-20130821


Old description:

> Attached files are wireshark sessions.
> It looks like that DHCP (bind10-1.0.0/src/bin/dhcp6/dhcp6_srv.cc) checks
> only presence of client_id/server_id in messages not it's content.
>
> file:
> all_with_blank_client_id refers to
> RFC 3315 Section 15.2
> "Servers MUST discard any Solicit messages that do not include a Client
> Identifier option" and 15.4, 15.5, 15.6, 15.7, 15.8,
>
> file:
> request_wrong_server_id refers to
> RFC 3315 Section 15.4
> "Servers MUST discard any received Request message that meet any of the
> following conditions:
>    -  the contents of the Server Identifier option do not match the
>       server's DUID" and probably to: 15.6, 15.8, 15.9 (not tested)

New description:

 Attached files are wireshark sessions.
 It looks like that DHCP (bind10-1.0.0/src/bin/dhcp6/dhcp6_srv.cc) checks
 only presence of client_id/server_id in messages not it's content.

 file:
 all_with_blank_client_id refers to
 RFC 3315 Section 15.2
 "Servers MUST discard any Solicit messages that do not include a Client
 Identifier option" and 15.4, 15.5, 15.6, 15.7, 15.8,

 file:
 request_wrong_server_id refers to
 RFC 3315 Section 15.4
 "Servers MUST discard any received Request message that meet any of the
 following conditions:
    -  the contents of the Server Identifier option do not match the
       server's DUID" and probably to: 15.6, 15.8, 15.9 (not tested)



 Client_id bug fixed recently, for server_id I'm attaching patch.
 Unfortunately, because of my local-machine little problems, patch
 performed without unitests.

--

-- 
Ticket URL: <http://bind10.isc.org/ticket/2892#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development