BIND 10 #3105: ParserContext::hooks_libraries_ is not copied in the assignment operator and copy constructor

BIND 10 Development do-not-reply at isc.org
Mon Aug 19 16:24:12 UTC 2013


#3105: ParserContext::hooks_libraries_ is not copied in the assignment operator
and copy constructor
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  marcin                             |                Status:  new
                       Type:         |             Milestone:  Sprint-
  defect                             |  DHCP-20130821
                   Priority:         |              Keywords:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DHCP
  dhcpconf                           |  Estimated Difficulty:  0
               CVSS Scoring:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 This ticket is a result of the cppcheck warning:
 {{{
 src/lib/dhcpsrv/dhcp_parsers.cc:54: check_fail: Member variable
 'ParserContext::hooks_libraries_' is not initialized in the constructor.
 (warning,uninitMemberVar)
 src/lib/dhcpsrv/dhcp_parsers.cc:65: check_fail: Member variable
 'ParserContext::hooks_libraries_' is not assigned a value in
 'ParserContext::operator='. (warning,operatorEqVarError)
 }}}

 which occurred here:
 http://git.bind10.isc.org/~tester/builder/BIND10-cppcheck/20130817040001-FreeBSD8-amd64-GCC/logs/cppcheck.out

 When working on the resolution, it turned out that the copy constructor
 and assignment operator do not deal with the NULL pointers. It also
 occurred that there were no unit tests for the !ParserContext class. With
 this ticket the missing tests have been added.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3105>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list