BIND 10 #3036: Modify DHCP6 to generate NameChangeRequest
BIND 10 Development
do-not-reply at isc.org
Tue Aug 20 10:15:42 UTC 2013
#3036: Modify DHCP6 to generate NameChangeRequest
-------------------------------------+-------------------------------------
Reporter: marcin | Owner:
Type: enhancement | marcin
Priority: medium | Status:
Component: dhcp-ddns | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-DHCP-20130821
Sub-Project: DHCP | Resolution:
Estimated Difficulty: 0 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by tomek):
* owner: tomek => marcin
Comment:
I reviewed the last 2 commits (aad0b789f4f82e50e219debc7d6d52675d7c85e0
and 586809ac7369b85efe135f62b6281e141d88bfdb). The code looks ok, but I
have minor comments. They do not require any code changes, though (perhaps
adding @todo). As far as I understand cryptolink, it is a generic
abstraction layer around a crypto library. We use botan for now, but other
lib could be supported later. So we use generic API to initalize the
library, but use specific implementation to do SHA calculations.
Also, documentation to cryptolink (src/lib/cryptolink/cryptolink.h:101)
mentions that initialized() method can be used. But I think it is ok to
keep the code as it is now.
--
Ticket URL: <http://bind10.isc.org/ticket/3036#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list