BIND 10 #3028: Cmdctl print_settings - conflict between behavior and help documentation

[BIND 10 Development]

#3028: Cmdctl print_settings - conflict between behavior and help documentation
-------------------------------------+-------------------------------------
            Reporter:  bconry        |                        Owner:
                Type:  defect        |  vorner
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130820
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Hi Michal

 Replying to [comment:9 vorner]:
 > Hello
 >
 > Replying to [comment:7 muks]:
 > > * Just remove it altogether (other commands like `shutdown` won't work
 without being handled in cmdctl). Also remove the commented line in
 `b10-cmdctl.xml`.
 >
 > I did something similar. Now I use the shutdown command for the test.

 Is it checked that `shutdown()` method is called in this case?

 > What comment line do you mean? I can't seem to find one.

 This line in `b10-cmdctl.xml`:
 {{{
 <!-- NOTE: print_settings is not documented since I think will be removed
 -->
 }}}

 > > * Put it in a derived class `MyCommandControl` that exists in
 `cmdctl_test.py` that calls `super()` for all other commands except
 `test_command`.
 >
 > That would make little sense. We would be testing that the derived class
 works and we wouldn't enter the real code in that test at all.

 I meant testing it as a virtual function where `command_handler()` is not
 invoked directly, but through some other method. In any case, the approach
 taken of removing this command entirely is good.

 > Proposed changelog:
 > {{{
 > [func]                vorner
 > The CmdCtl's command "print_settings" was removed. It served no real
 purpose
 > and was just experimental leftover from early development.
 > }}}

 This is good too.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3028#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development