BIND 10 #2762: unable to add a TSIG key with algorithm HMAC-MD5

[BIND 10 Development]

#2762: unable to add a TSIG key with algorithm HMAC-MD5
-------------------------------------+-------------------------------------
            Reporter:  cas           |                        Owner:
                Type:  defect        |                       Status:  new
            Priority:  medium        |                    Milestone:  Next-
           Component:  bind-ctl      |  Sprint-Proposed
            Keywords:                |                   Resolution:
           Sensitive:  0             |                 CVSS Scoring:
         Sub-Project:  Core          |              Defect Severity:
Estimated Difficulty:  3             |  Medium
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by shane):

 So it looks like the main change needs to happen in tsigkey.cc:

 {{{#!c++
 const
 Name& TSIGKey::HMACMD5_NAME() {
     static Name alg_name("hmac-md5.sig-alg.reg.int");
     return (alg_name);
 }
 }}}

 However, the hmac-md5.sig-alg.reg.int literally appears in many places
 throughout the code. :(

 So, probably we also want to add a special case in the
 !ConvertAlgorithmName() function:

 {{{#!c++
     HashAlgorithm
     convertAlgorithmName(const isc::dns::Name& name) {
         if (name == TSIGKey::HMACMD5_NAME()) {
             return (isc::cryptolink::MD5);
         }
         // also get the official MD5 name
         if (name == "hmac-md5.sig-alg.reg.int") {
             return (isc::cryptolink::MD5);
         }
 }}}

 We can probably leave the rest of the code as it is, but will need to add
 a test case or two with the "hmac-md5" name.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2762#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development