BIND 10 #3121: Move error detection logic from commit()s to builds() in d2_config.cc

[BIND 10 Development]

#3121: Move error detection logic from commit()s to builds() in d2_config.cc
-------------------------------------+-------------------------------------
                   Reporter:  tmark  |                 Owner:
                       Type:         |                Status:  new
  defect                             |             Milestone:  New Tasks
                   Priority:  low    |              Keywords:
                  Component:  dhcp-  |             Sensitive:  0
  ddns                               |           Sub-Project:  DHCP
               CVSS Scoring:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 The DHCP_DDNS parsers in d2_config.cc conduct most of their validation
 logic in their commit methods when in fact, the configuration paradigm
 calls for this work to be done in the build methods.  The parsing
 functions correctly as is but it is not structured as intended by the
 underlying infrastructure.

 Since the parses in d2_config currently all follow a consistent pattern of
 implementation the restructure should likewise be consistent throughout.

 See review comments on trac3075 from Marcin regarding TSIGKeyInfo parsing
 for additional background.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3121>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development