BIND 10 #3099: Bogus error message in b10-xfrin if no tsig key used

[BIND 10 Development]

#3099: Bogus error message in b10-xfrin if no tsig key used
-------------------------------------+-------------------------------------
            Reporter:  shane         |                        Owner:  shane
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  xfrin         |                    Milestone:
            Keywords:                |  Sprint-20130903
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  1             |              Defect Severity:
         Total Hours:  0             |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => shane


Comment:

 Hello

 Replying to [comment:7 shane]:
 > Ah good point!
 >
 > Actually I was thinking it makes sense to simply leave the TSIG out...
 after all we're talking about an error with the TCP connection which
 occurs independent of TSIG. I'm not really sure why the TSIG was included
 in the message to begin with.

 OK, that makes sense.

 It was included in the message simply because I added the TSIG names to
 the messages in carpet-bombing fashion in some ticket asking for them.

 > The set_tsig_key_name() method is operating on a !ZoneInfo object, and
 the reference that I've removed is in the !XfrinConnection class.

 Ah, right, that'd explain it.

 > Surely there are also deeper issues, but we know the XFR code needs to
 be refactored so I'm not sure we need to dig into it too much...

 Right, in this situation, it is not related, so it is OK.

 Please merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3099#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development