BIND 10 #3113: Hooks unit-tests fail when --enable-static-link is used
BIND 10 Development
do-not-reply at isc.org
Fri Aug 30 17:49:10 UTC 2013
#3113: Hooks unit-tests fail when --enable-static-link is used
-------------------------------------+-------------------------------------
Reporter: tomek | Owner:
Type: defect | UnAssigned
Priority: medium | Status:
Component: dhcp | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-DHCP-20130904
Sub-Project: DHCP | Resolution:
Estimated Difficulty: 0 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by marcin):
* owner: => UnAssigned
* status: new => reviewing
* milestone: DHCP Outstanding Tasks => Sprint-DHCP-20130904
Comment:
I made necessary changes and committed them to the branch.
This patch disables static linking of the unit tests which use hooks. The
shared test libraries have to be linked with the b10-libraries, such as
logger and hooks. If unit tests are linked statically with these libraries
we end up with two copies of logger, hooks lib etc. These libs are
stateful (have static global objects), so having distinct copies of them
does not make any sense. In order to allow these objects to be shared
between the unit test and the shared test libs, the linked b10-libs must
be linked dynamically.
Having said that, I wonder if we should update the documentation to point
out that the programs using hooks should be linked dynamically, unless the
shared libraries implementing callouts do not depend on the stateful
b10-libs.
{{{
6XX. [bug] marcin
Disabled static linking of unit tests using hooks. This allows
to share the b10 libraries between the unit tests and libraries
implementing hooks. This prevents the unit tests failures
when --enable-static-link configure flag is specified.
(Trac #3113, git abcd)
}}}
--
Ticket URL: <http://bind10.isc.org/ticket/3113#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list