BIND 10 #2103: [kean] change error_code in recursive_query_unittest_3.cc (was: [kean] free error_code in recursive_query_unittest_3.cc)

BIND 10 Development do-not-reply at isc.org
Mon Dec 2 14:18:20 UTC 2013


#2103: [kean] change error_code in recursive_query_unittest_3.cc
-------------------------------------+-------------------------------------
            Reporter:  fdupont       |                        Owner:  muks
                Type:  defect        |                       Status:
            Priority:  high          |  reviewing
           Component:  Unclassified  |                    Milestone:
            Keywords:                |  Sprint-20131015
           Sensitive:  0             |                   Resolution:
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  2             |              Defect Severity:
         Total Hours:  0             |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by kean):

 * owner:  kean => muks


Comment:

 valgrind doesn't report a leak the old way either. I think the word "free"
 in the title is misleading. However all other code uses asio::error_code
 so at the very least this is warranted for consistency. The description
 says to change error_code to asio::error_code, I wouldn't attach too much
 importance to the word "free" in the title. Nowhere in the bug does it
 imply a leak (other than that 1 word). Since it is misleading changing
 that word to "change" since that is what both the description and the
 patch file indicate is appropriate.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2103#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list