BIND 10 #3267: perfdhcp: prefer including local files, rather than files from the top dir location

BIND 10 Development do-not-reply at isc.org
Thu Dec 19 18:26:01 UTC 2013


#3267: perfdhcp: prefer including local files, rather than files from the top dir
location
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:  kean
                Type:  defect        |                       Status:
            Priority:  low           |  reviewing
           Component:  perfdhcp      |                    Milestone:  DHCP
            Keywords:                |  Outstanding Tasks
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  Low
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => kean


Comment:

 Reviewed commit 3ff790761f37375de1f9eff59872405fc26e0364

 '''rate_control_unittest.cc'''
 Shouldn't it be:
 {{{
 #include "../rate_control.h"
 }}}
 instead of:
 {{{
 #include "rate_control.h"
 }}}
 ?


 Also, this line:
 {{{
 AM_CPPFLAGS += -I$(top_builddir) -I$(top_srcdir)
 }}}
 is now unnecessary in tests/tools/perfdhcp/Makefile.am and
 tests/tools/perfdhcp/tests/Makefile.am

 and can be removed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3267#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list