BIND 10 #2390: support generic version of rdata::createRdata(text) in NS, MX, PTR RDATA

BIND 10 Development do-not-reply at isc.org
Fri Feb 1 02:32:45 UTC 2013


#2390: support generic version of rdata::createRdata(text) in  NS, MX, PTR RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  jelte
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130205
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  4             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jelte


Comment:

 Replying to [comment:18 jelte]:
 > The changes look fine, and apart from a potential changelog i think it
 can be merged.

 How does this look (for both #2390 and #2656):
 {{{
 XXX.    [func]          muks
         libdns++: the CNAME, DNAME, MX, NS, PTR and SRV Rdata classes now
         use the generic lexer in constructors from text.  This means that
         the name fields in such RRs in a zone file can now be non-absolute
         (the origin name in that context will be used), e.g., when loaded
         by b10-loadzone. One additional change to the libdns++ API is that
         the existing string constructors for these Rdata classes also use
         the generic lexer, and they now expect an absolute name (with the
         trailing '.') in the name fields.
         (Trac #2390, git ...)
         (Trac #2656, git ...)
 }}}

 > Regarding the ip address thing, not sure if I understand your question;
 we could possible add something that warns if a domain name looks like an
 ip address, like bind9 does. Personally I don't really think it is that
 useful but it would be 'like what bind9 does' :) In that case I suspect it
 should go into createNameFromLexer (or probably better: a second function
 like that that gets the callbacks as well). Either way I think we can do
 that in a separate ticket, as it's probably not just for NS.

 OK I'll just leave this for now.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2390#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list