BIND 10 #2157: Create an interface to pass statistics counters in Auth module
BIND 10 Development
do-not-reply at isc.org
Sat Feb 2 03:54:46 UTC 2013
#2157: Create an interface to pass statistics counters in Auth module
-------------------------------------+-------------------------------------
Reporter: y-aharen | Owner:
Type: enhancement | jinmei
Priority: medium | Status:
Component: b10-auth | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130205
Sub-Project: DNS | Resolution:
Estimated Difficulty: 8 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:55 y-aharen]:
I made a few minor editorial fixes.
And there's some last suggestions to the man page:
- I'd say just "TSIG" instead of "signature" because, after all,
that's what we are doing (not currently support SIG(0)), and
because "signature" could be confusing in the context of DNSSEC.
- I'd explain why we count opcode regardless of the TSIG result.
My suggested text is as follows:
{{{
<para>
Request attributes except for opcode will not be counted if TSIG
validation failed as they are not reliable.
We always count opcode mainly for compatibility with BIND 9,
but remember that if there's any error related to TSIG, some
of the counted opcode may not be trustworthy.
</para>
}}}
If you are okay with it, apply it and go merge. But, I'd suggest
making sure you have enough time to watch buildbot reports and fix
any possible regressions in a timely fashion. Large changes like this
normally cause several regressions, so we should expect them. Please
don't just merge it and then go to ski resort:-)
And, finally, a few notes on merge:
- please don't forget creating tickets for things deferred from this
ticket.
- please don't forget adding changelog.
--
Ticket URL: <http://bind10.isc.org/ticket/2157#comment:56>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list