BIND 10 #1866: isc.dns constants like RRType.A() should be constants, not functions
BIND 10 Development
do-not-reply at isc.org
Mon Feb 4 16:06:40 UTC 2013
#1866: isc.dns constants like RRType.A() should be constants, not functions
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | jinmei
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130205
Sub-Project: DNS | Resolution:
Estimated Difficulty: 5 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:14 vorner]:
Some points first:
> The tests fail for me:
> {{{
> Running test: session_tests.py
> ...F..........F..........................
> ======================================================================
> FAIL: test_convert_rrset_class (__main__.SessionModuleTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
"/tmp/bind10-1/bind10-20121219/_build/../src/lib/python/isc/ddns/tests/session_tests.py",
line 136, in test_convert_rrset_class
> }}}
This doesn't happen to me. Are you sure to run it with the latest
isc.dns wrapper? Does it pass if you start from make clean?
> Why do you generate the code into a variable and accumulate it across
all the RRtypes and then dump it after each new one? This seems like a
quadratic run time and it looks unnecessary. Would it make sense to output
it just once at the end?
I don't understand this comment. Specifically which part of the code
are you referring to?
--
Ticket URL: <http://bind10.isc.org/ticket/1866#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list