BIND 10 #1901: be consistent with bind10 or boss or bob name

[BIND 10 Development]

#1901: be consistent with bind10 or boss or bob name
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  Boss of BIND  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130205
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  9             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Replying to [comment:11 jinmei]:
 > First, I have to admit that my check in review was not fully
 > word-by-word, so I may have missed something.  But I think we don't
 > have to be perfect in this attempt, as long as it generally works
 > correctly.
 >

 ack.

 > '''general/others'''
 >
 > - distcheck failed for me.  please check.

 doh, needed to add to EXTRA_DIST

 > - regarding the path to b10-init (under libexec), I think we should
 >   hardcode the path (autogenerated by ./configure from a .in file).
 >   both for the "bind10" run_bind10 scripts.

 ack for 'bind10' itself, but I disagree about run_bind10, since it's
 purpose is to run from the source tree and not prefix/libexec :)

 updated

 > - maybe we need a man page for the top level "bind10" script?

 added, but is is rather simple :p

 > - I assume in cfa26ab8df9b533d32b8dd5aa405bf237bb58f12 you only
 >   changed file name (with trivial Makefile.am fixups) without
 >   modifying the contents.

 yes

 > - Is it a good idea to replace "Boss" in !ChangeLog entries?  I'd
 >   personally leave them as they were historical notes.  besides, if we
 >   want to change !ChangeLog, it's incomplete: there are still some
 >   occurrences of "boss" or "Bob" (and maybe "bind10" that would have
 >   to be replaced with "init")

 No it is not, I wasn't sure about it, but had decided over the weekend
 that I should revert this :)

 > - in bind10/README, is the phrase of "Init of Bind" intentional?
 > {{{
 > This directory contains the source for the "Init of Bind" program.
 > }}}
 >   Same comment applies to b10-init.py.  Maybe okay, but I guess we
 >   need to define this term somewhere.  We might also note that in doc
 >   etc we use other terms like just "init/Init" or "b10-init"
 >   interchangeably.

 Yeah that first one was wrong (there were bound to be a few of those with
 this many replacements :P)

 But in general, I do indeed make a subtle distinction between init/Init
 and b10-init; I use the former one usually when talking about the class,
 or the abstract context of what 'the thing' does, while the latter tends
 to refer to the actual program, but I guess not in all contexts it is
 clear which one would be best to use. Not sure where we would canonically
 define this though.

 > - b10-init.xml: "init" should be capitalized?
 > {{{#!diff
 > -      The <varname>Boss</varname> configuration commands are:
 > +      The <varname>init</varname> configuration commands are:
 > }}}

 ack.

 > - init.spec: not really for the topic of this task, maybe rephrase
 "Master
 >   process", too?
 > {{{#!diff
 > -    "module_name": "Boss",
 > +    "module_name": "Init",
 >      "module_description": "Master process",
 > }}}

 changed to Init, but wondering whether this two-word description is useful
 in its current form :)

 > - init_message.mes: is the "IN" garbage?
 > {{{#!diff
 > -# Copyright (C) 2011  Internet Systems Consortium, Inc. ("ISC")
 > +IN# Copyright (C) 2011  Internet Systems Consortium, Inc. ("ISC")
 > }}}

 whoa. Yes. Interesting how that doesn't make things go boom...

 > - can't we name the Python source file just "init.py" and convert it
 >   to b10-init, just like xfrin, ddns, etc?  Then we won't need the
 >   trick like that in bind10_test.py.  (btw, 'bind10_test.py' may also
 >   have to be renamed)

 underscores are fine if that is what you meant

 changed to do the same thing. I also updated a few more tests as it got a
 bit grumpy about local variables and modules (so the module is 'init' and
 vars are 'b10_init')

 > - bind10_test.py.in: not for this branch, but s/Hijact/Hijack/?
 > {{{#!diff
 > -        Hijact the accept method of the boss.
 > +        Hijact the accept method of the b10-init.
 > }}}
 >

 while not for this branch per se, i see no reason not to fix these now, so
 done

 > '''bindctl_main.py.in'''
 >
 > - Not for this branch, but I'd change 'Recurse' to 'Auth'.  At least
 >   it shouldn't be 'Recurse' (which doesn't exist):
 > {{{#!python
 > DEFAULT_IDENTIFIER_DESC = "The identifier specifies the config item.
 Child elements are separated with the '/' character. List indices can be
 specified with '[i]', where i is an integer specifying the index, starting
 with 0. Examples: 'Init/start_auth', 'Recurse/listen_on[0]/address'. If no
 identifier is given, shows the item at the current location."
 > }}}
 >

 changed

 > '''b10-ddns.xml'''
 >
 > - it's probably better to be "with the b10-init process".
 > {{{#!diff
 > -            compatibility with the <command>bind10</command> Boss
 process.
 > +            compatibility with the <command>bind10</command> Init
 process.
 > }}}
 >

 fixed. This one occurred in more xmls which i have also updated
 (<command>bind10</command> which should have been
 <command>b10-init</command>)

 > '''b10-stats-httpd.xml'''
 >
 > - remove "(<command>bind10</command>)"?
 > {{{#!diff
 > -      by the BIND 10 boss process (<command>bind10</command>) and
 eventually
 > +      by the b10-init process (<command>bind10</command>) and
 eventually
 > }}}
 >

 done.

 >
 > '''cfgmgr.py'''
 >
 > - I'm not sure how likely a config has both `Boss` and `Init`, but
 >   isn't it better to warn about it (in a log) if that happens?
 >

 unlikely, and only if some external person or tool tried to be smart.
 Added a log message explaining what it does and why

 > '''lettuce tests'''
 >
 > - Shouldn't we update the version of the configurations?  e.g.
 >   lettuce/configurations/bindctl/bindctl.config has this:
 > {{{
 >     "version": 2,
 > }}}

 ohyeah :) done

-- 
Ticket URL: <http://bind10.isc.org/ticket/1901#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development