BIND 10 #2145: imports in isc/__init__.py
BIND 10 Development
do-not-reply at isc.org
Wed Feb 6 04:02:52 UTC 2013
#2145: imports in isc/__init__.py
-------------------------------------+-------------------------------------
Reporter: jelte | Owner:
Type: defect | jinmei
Priority: high | Status:
Component: Unclassified | accepted
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130219
Sub-Project: Core | Resolution:
Estimated Difficulty: 3 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
trac2145 is ready for review.
changes up to 39c1d35 are the main part of the branch. This should be
pretty straightforward. The question is whether these are sufficient.
I confirmed that unit tests, system tests, and lettuce tests passed
(with an unrelated fix, see below) run_bind10 and run_bindctl worked,
installed system worked. I also ran the branch on buildbots, and
they reported lettuce and distcheck failures:
http://git.bind10.isc.org/~tester/builder/BIND10-distcheck/20130206011939-FreeBSD8-i386/logs/distcheck.out
http://git.bind10.isc.org/~tester/builder/BIND10-lettuce/20130206004924-MacOSX10.6-x86_64-GCC/logs/lettuce.out
but I couldn't reproduce these. For now, I'd get it reviewed, and if
these issues don't happen either, merge it and check the buildbot again.
Commit 0749f9e is not really an issue of this task, but a kind of a
regression due to #1901. Without this change in-source lettuce tests
don't work. Since it's only for lettuce tests, I think it's okay to
piggy back the fix on this ticket.
Commit 3a185f5 is one additional cleanup related to the ticket, which
shouldn't be controversial.
The last commit 64fb39c is an unrelated cleanup, but I thought this is
better.
I don't plan to add a changelog entry for this task. It's basically
an internal cleanup and not user-visible.
--
Ticket URL: <http://bind10.isc.org/ticket/2145#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list